Allow simple assignment statements in check() calls

meteor / eslint-plugin-meteor

🧐 Meteor specific linting rules for ESLint

https://medium.com/@dferber90/8f229ebc7942

MIT License

118 stars 20 forks source link

Allow simple assignment statements in check() calls #785

Closed edemaine closed 3 years ago

edemaine commented 3 years ago

My custom check helpers return values. This PR adds support for getting these return values while still considering the check function called.

It would be nice to be more general than just simple assignment statements (open to ideas!), but this is at least an improvement and suffices for my needs.

dferber90 commented 3 years ago

@edemaine Thanks for this PR! Could you update the documentation to mention these new capabilities at docs/rules/audit-argument-checks.md?

edemaine commented 3 years ago

Documentation added — let me know if you have comments for revision, or feel free to change things yourself.

dferber90 commented 3 years ago

Thanks for adding this! It's now out as v7.3.0 👍

edemaine commented 3 years ago

Thanks for the quick review and release! I confirm that it works well in my project.