search

meteor / meteor-feature-requests

A tracker for Meteor issues that are requests for new functionality, not bugs.
Other
89 stars 3 forks source link

Avoid rebuilding the app three times on error #335

Closed vbgm closed 3 years ago

vbgm commented 5 years ago

Description Since Meteor tries to restart the app three times when there is a development server runtime error, it takes longer time to read error logs, since they are published 3 times.

Suggestion Make the count of restarts as an option or environment variable.

Details This has been requested firstly in meteor/meteor#6481, but was closed and suggested to create a feature request.

benjamn commented 5 years ago

I like this idea, and I would even go further: instead of allowing the restart count to be configured, let's get rid of the multiple restart feature altogether. In more than four years working on Meteor, I have never once seen the second or third restart actually fix any problems.

vbgm commented 5 years ago

Great that you like it! I have not seen the second or third restart actually fix any problem, but maybe someone had.. :-)

benjamn commented 5 years ago

If you (or anyone) is interested in attempting a pull request, here's the relevant code. Of course you could just change that 3 to a 1, but ideally we could clean up any lingering multiple restart logic too.

StorytellerCZ commented 3 years ago

This has been implemented in Meteor 1.9