Make version switcher option color darker

meteor / meteor-theme-hexo

The framework we use for docs.

https://docs-docs.netlify.com/docs/docs/

MIT License

64 stars 26 forks source link

Make version switcher option color darker #85

Closed hwillson closed 5 years ago

hwillson commented 6 years ago

Fixes an issue on IE and in Linux browsers, where the version switcher options weren't showing up as the font color was too light. Thanks!

abernix commented 6 years ago

Looks a bit too dark on my Mac Chrome.

hwillson commented 6 years ago

Sorry, do you mean the options look too dark?

screenshot 2018-07-05 08 17 22

I can definitely lighten them up. I just used the same color as the header background, but it looks a little too bold. Let me know if that's what you mean and I'll adjust. Thanks!

hwillson commented 6 years ago

I've adjusted the font weight a bit:

screenshot 2018-07-05 09 19 52

Let me know if that works!

abernix commented 6 years ago

Sorry for not being more clear. It was hard to tell from my screenshot that the current version is supposed to be listed to the left of the dropdown arrow. For example, in the following screenshot the "2" is part of the dropdown itself.

So it seems that the changing of the font color to match the header background (as this PR does) fixes the viewing of the version numbers in the dropdown box (itself), but has the unintended side-effect of making the currently selected version number disappear (in non-expanded mode).

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}