search

meteor / meteor

Meteor, the JavaScript App Platform
https://meteor.com
Other
44.06k stars 5.16k forks source link

Fix for old API usage #13096

Closed manueltimita closed 3 weeks ago

manueltimita commented 4 weeks ago

Fixes "Error in OAuth Server: findOne + is not available on the server. Please use findOneAsync() instead."

The error stems from oauth_server.js still using the sync Mongo API at ServiceConfiguration.configurations.findOne(...)

CLAassistant commented 4 weeks ago

CLA assistant check
All committers have signed the CLA.

StorytellerCZ commented 4 weeks ago

Is this for the current 2.x version or 3.x. I have fixed at least the second part in 3.x already.

manueltimita commented 4 weeks ago

I'm using oauth@3.0.0-beta300.7 in development, where the error surfaced, so my intention was to fix it in 3.x. If you fixed it already, it looks like I misunderstood how the devel branch works in this repo. I think we can close this then.

StorytellerCZ commented 3 weeks ago

Check out the latest release-3.0 branch. If you want to merge into 3.0 then you need to target that branch.

manueltimita commented 3 weeks ago

Thanks, will do that in the future.