Closed jasonk closed 4 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
I was trying to use
makeCompatible
to add Meteor support to the bluebird promises library, like this:This didn't work correctly and resulted in the error message
this.resolve is not a function
whenever I attempted to usePromise.await
orPromise.awaitAll
. I tracked the error down to the implementation ofawait
andawaitAll
usingthis.resolve
andthis.all
, and apparently assuming that the context would havethis
set to the promise implementation when that happened. In my environment I found this wasn't the case (instead I hadthis === global
). By making the small change that is in this PR (simply replacingthis
withPromise
in those two class methods) I was able to get it to work.