meteor / react-packages

Meteor packages for a great React developer experience
http://guide.meteor.com/react.html
Other
573 stars 158 forks source link

Allow using component name instead of component #164

Closed bitomule closed 8 years ago

bitomule commented 8 years ago

It would be great if we can just use the component name instead of a component reference.Why can't we just pick the component from global? That would remove the need for a template helper returning the component. This small change won't break anything, just adds componentName option. With this change package can be used just with:

{{> React componentName="MyComponent" prop1="Hello"}}
apollo-cla commented 8 years ago

@bitomule: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

tmeasday commented 8 years ago

I think we want to move away from things being global (see the theme of the 1.3 release), especially in the React world where they don't have to be.

Thanks though!