Remove "react-addons-pure-render-mixin"?

meteor / react-packages

Meteor packages for a great React developer experience

http://guide.meteor.com/react.html

Other

573 stars 158 forks source link

Remove "react-addons-pure-render-mixin"? #200

Closed MHerszak closed 7 years ago

MHerszak commented 8 years ago

I have a question. In regards to this post, https://facebook.github.io/react/blog/2016/07/13/mixins-considered-harmful.html#solution would it be possible to remove "react-addons-pure-render-mixin" from "react-meteor-data"? They suggest to start using var shallowCompare = require('react-addons-shallow-compare'); for shouldComponentUpdate I am not sure if this is possible or not? Thanks

MHerszak commented 8 years ago

Nvm. I just checked shallowCompare and it has a dependency to lodash lodash.keys. It would make sense to for us to utilize underscore to mimic shallowCompare.

MentalGear commented 7 years ago

I think now the recommend the use of PureComponent in the react guide.