search

meteor / react-packages

Meteor packages for a great React developer experience
http://guide.meteor.com/react.html
Other
573 stars 158 forks source link

export createContainer (in the package.js) #205

Closed Bramas closed 7 years ago

Bramas commented 8 years ago

after doing console.log(require('meteor/react-meteor-data')); I realized that createContainer is not exported by the package. And, it's normal because in the package.js, only ReactMeteorData is exported.

So even the trivial example starting with import { createContainer } from 'meteor/react-meteor-data'; fails.

I just added createContainer in the export like it should be.

apollo-cla commented 8 years ago

@Bramas: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

dburles commented 7 years ago

I don't believe this is still an issue, @Bramas ?

Bramas commented 7 years ago

Sorry but I don't know (I think you can close it if there's no issue related to that)

hwillson commented 7 years ago

Closing as this should no longer be an issue. Thanks!