search

meteor / react-packages

Meteor packages for a great React developer experience
http://guide.meteor.com/react.html
Other
574 stars 159 forks source link

add deprecation warning to createContainer #236

Closed dburles closed 7 years ago

dburles commented 7 years ago

Required a bit of refactoring. It makes much more sense to directly export the connect function as withTracker.

dburles commented 7 years ago

Hey @hwillson @abernix mind taking a look at this before it's merged?

abernix commented 7 years ago

Published as react-meteor-data@0.2.15! Thanks, @dburles!

s7dhansh commented 7 years ago

@dburles Since withTracker is now an alias of createContainer, it displays the warning even when you use withTracker.

dburles commented 7 years ago

Hey @s7dhansh this commit also removed the alias so you definitely shouldn’t be seeing the warning. Are you certain that your app is no longer using createContainer?

s7dhansh commented 7 years ago

Yes, I have checked my files completely. I will check the packages and let you know.

On Thu 9 Nov, 2017, 1:51 AM David Burles, notifications@github.com wrote:

Hey @s7dhansh https://github.com/s7dhansh this commit also removed the alias so you definitely shouldn’t be seeing the warning. Are you certain that your app is no longer using createContainer?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meteor/react-packages/pull/236#issuecomment-342947148, or mute the thread https://github.com/notifications/unsubscribe-auth/AArJtAcTxu4mzdN2nPVtp4fX4upYbcZSks5s0g1RgaJpZM4P07xU .

-- Sudhanshu