meteor / react-packages

Meteor packages for a great React developer experience
http://guide.meteor.com/react.html
Other
571 stars 157 forks source link

Fix lost reactivity when using deps #314

Closed CaptainN closed 3 years ago

CaptainN commented 3 years ago

This attempts to fix various lost reactivity reports, as well as some trouble with a particular "Maximum update depth exceeded" error, coming from (possibly) constantly updating deps interaction with useEffect, in two ways:

All tests are passing, but I'd like to see if we can work out a test to confirm the reported error.

313

CaptainN commented 3 years ago

We have at least one validation that the approach in this PR fixes the reported issue. @filipenevola Due to the severity of this bug, I don't think we should wait for a test - we should release a new version 2.2.2.

https://github.com/meteor/react-packages/issues/313#issuecomment-769018365

make-github-pseudonymous-again commented 3 years ago

Repeating what I said in #306: