Closed edemaine closed 2 years ago
Thanks so much for taking the time to produce a PR! I'll review and get back to you soon.
I actually think this is kind of important to fix and ship. cc: @StorytellerCZ
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: CaptainN
:white_check_mark: edemaine
:x: Kevin Newman
This is good to go. I'm not sure why the CLA thing is failing though.
@edemaine Great point. To be completely honest, I just wasn't sure Meteor's build pipeline supports ??
but yeah, it should totally use that. Feel free to make the change, or I can do it later. Thanks!
Hey @CaptainN and @edemaine, as soon as this last matter is figured out, let me know, and I'll release these changes. :palms_up_together:
To be completely honest, I just wasn't sure Meteor's build pipeline supports
??
but yeah, it should totally use that.
I believe ??
was introduced at the same time as ?.
, so should be safe.
Feel free to make the change, or I can do it later.
Done! This should be good to go now.
Version 2.5.1 is now up :tada:
Fixes #334, as described in this comment.
Before this PR, server-side
useFind
printed a warning and returned[]
. After this PR, the warning is gone and the correctcursor.find()
results are returned.