search

meteor / react-packages

Meteor packages for a great React developer experience
http://guide.meteor.com/react.html
Other
574 stars 159 forks source link

Packages are missing licenses and copyright notice #401

Closed wkeithchau closed 10 months ago

wkeithchau commented 11 months ago

The licenses and copyright notices are missing from the repo. Would these packages be using the same copyright notice as the main Meteor repo? Possible to release new versions with licensing.

radekmie commented 11 months ago

Not a lawyer, but I think that the "license": "MIT" line in package.json should be enough.

StorytellerCZ commented 11 months ago

I do recall a few years back that for corporate people a dedicated license file is needed. Is that correct @wkeithchau

wkeithchau commented 11 months ago

Yep, you're spot on @StorytellerCZ . At least for us, the license file needs to be attached to a published version. If you add a license file now, the current version still isn't valid. A new version needs to be released (I don't believe we can install Meteor packages based off of a GitHub URL/commit?).

StorytellerCZ commented 11 months ago

You can copy them locally and use them.

wkeithchau commented 10 months ago

Can a new version of the package be created as well? Our legal is quite finicky. The recently added license cannot be applied retrospectively. We would usually reference a git tag (which looks out-of-sync) or a git commit. The git commit for the latest version (2.7.2) does not include the license file that we need.

StorytellerCZ commented 10 months ago

@Grubba27

Grubba27 commented 10 months ago

Like this? https://github.com/meteor/react-packages/releases/tag/react-meteor-data%402.7.2

wkeithchau commented 10 months ago

That will help make referencing the source code easier. I was thinking more of a version bump (and new version published) since 2.7.2 was released prior to the license being added.

StorytellerCZ commented 10 months ago

Also having the LICENSE file at the root of the repository is enough or does it have to also be in the folder from which the package is published as well?

wkeithchau commented 10 months ago

At the root directory of the repository is fine.