search

meteor / react-tutorial

React Tutorial is the best place to learn how to use React and Meteor together
https://react-tutorial.meteor.com/
39 stars 87 forks source link

Update Task.jsx to have correct className #15

Closed shadoath closed 3 years ago

shadoath commented 3 years ago

New Styling in step 5.2 does not outline this change.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

shadoath commented 3 years ago

Bump, can this be merged?

filipenevola commented 3 years ago

Hi @shadoath, sorry for the delay here.

Thank you for your PR, we really appreciate it.

Important comment: every step starts from the state of the last one.

So could you change your PR to include your changes on all further steps (step06, 07 ...)? Like

Otherwise I will need to reject this PR and make this change in a new PR because we can't have steps out of sync.

shadoath commented 3 years ago

@filipenevola All steps update to match. Thank you for pointing that out. Also merged changes from master.

filipenevola commented 3 years ago

Hi, the problem was in the instruction and not in the code, we don't have "task" className in the code.

It's fixed here https://github.com/meteor/react-tutorial/commit/39fa511078abe4998ba109386591814dca568d69.

Thank you for your contribution 😉