meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 365 forks source link

React branch uses reactRouter not flowRouter #134

Closed TimeBandit closed 8 years ago

TimeBandit commented 8 years ago

The meteor guide emphasises and explains flowRouter but then the react branch of the todos app uses reactRouter. I think it's a bit of a discrepancy making the guide out of synch with the app code.

lorensr commented 8 years ago

I think it's more that the Guide recommends FR for Meteor in general, and not necessarily for React, and just doesn't want to get into explaining multiple routers. React router is more familiar to people coming from React, and perhaps is better (see eg Base switching to it). Let's see what Tom thinks

TimeBandit commented 8 years ago

Yes I see your point and it is a good point but if that were the case it could be argued that the todos-react example is servicing people coming from React into Meteor better than people coming from Meteor into React. Which group are more important to MDG?

tmeasday commented 8 years ago

In the React guide, we mention that both routers are commonly used with Meteor: http://guide.meteor.com/react.html#routing

We went with React Router for the React todos because it's more useful for people to see the contrast of how they are used. You can compare it to how Flow Router is used in the Blaze example in a pretty straightforward way.

TimeBandit commented 8 years ago

fair point thanks :)