search

meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

Modified validation options in ValidatedMethod definitions to referen… #143

Closed rhettlivingston closed 8 years ago

rhettlivingston commented 8 years ago

…ce the existing schema instead of creating new schemas from scratch. To support this, an _id field was added into the existing schemas. Also, aldeed:collection2 was updated from 2.5.0 to the latest 2.9.1 in order to support the usage of the _id field (ddp rate test failed due to false validation error).

Addresses issue #77

tmeasday commented 8 years ago

@stubailo what do you think about this? Seems like a reasonable step to me. Are there implications of adding an _id field to the original schema?

rhettlivingston commented 8 years ago

Note that I stopped short of using "rlivingston:simple-schema-mixin" though I was sorely tempted :-)

I didn't feel it appropriate - felt that it covers up too much of the ValidatedMethod basics for the beginners.

stubailo commented 8 years ago

This is a bit verbose but seems fine to me! Definitely something that could be nicer in simple schema.

rhettlivingston commented 8 years ago

So, are we good on this one?

tmeasday commented 8 years ago

Sorry, thanks @rhettlivingston.

rhettlivingston commented 8 years ago

You're welcome! This should close #77.

tmeasday commented 8 years ago

Are the tests failing on this branch?

tmeasday commented 8 years ago

Hmm, it claimed not, maybe just a furphy

rhettlivingston commented 8 years ago

They had not been. I'll be double checking shortly.

tmeasday commented 8 years ago

Nah, all good, I broke the installer in other news ;)