search

meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

Useraccounts configuration fix #149

Closed jdivy closed 8 years ago

jdivy commented 8 years ago

Create startup configuration for both client and server; Fix useraccounts

Fixes #148, in particular the reset password functionality, but perhaps other things as well.

apollo-cla commented 8 years ago

@jdivy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

LiamBigelow commented 8 years ago

Would also be wise to include the verifyEmail route

AccountsTemplates.configureRoute('verifyEmail', {
  name: 'verify-email',
  path: '/verify-email',
});

Otherwise the email verification options hit a page not found.

rub1e commented 8 years ago

This looks good - I was about to do a similar PR before I saw this - discussion on meteor forum here.

@jdivy for my own edification, is there a reason you moved the routes to the configuration file, or just personal preference? (I can see it both ways, just curious)

stubailo commented 8 years ago

Did we ever do the verifyEmail thing? Also, does this app even require emails to be verified?

jdivy commented 8 years ago

@rub1e I just decided to lump all of the useraccounts config into one file, including routes as well of course, since (in my head at least) it requires unique treatment. I guess it made more sense to put all the useraccounts stuff in one place at the time.

@stubailo I don't think the app ever actually exercises the verify email workflow, for what it's worth, but I'm not 100% positive

Also, I noticed that @tmeasday is working on transitioning the entire app to Apollo ( 👍 ) in #167 so this PR is perhaps completely moot. Would be nice to transfer the proper configuration into it though, so something to keep in mind!

stubailo commented 8 years ago

We're doing the apollo thing mostly as an experiment. We're probably going to focus on a different example app to start with, but this can be a good training ground for migration strategies.