meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

Installation of devDependencies in todos-react not skipped when installing node modules #151

Closed tab00 closed 7 years ago

tab00 commented 8 years ago

In the react branch, installation of devDependencies are not skipped when using npm install --production or

npm set config production
npm install

The resulting app in production has around 17,000 unnecessary files.

The problem does not appear in the Blaze version (installation of devDependencies are skipped as expected).

tab00 commented 8 years ago

I have found that removing the following from npm-shrinkwrap.json fixes the problem:

enzyme
eslint
eslint-config-airbnb
eslint-plugin-meteor
eslint-plugin-react
meteor-node-stubs
hwillson commented 7 years ago

The shrinkwrap files have been removed from both the master (Blaze) and react branches, so this is no longer an issue. Closing.