search

meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

Update mocha packages #153

Closed aldeed closed 8 years ago

aldeed commented 8 years ago

Updates the mocha packages to no longer conflict with one another

serut commented 8 years ago

When I try to test my meteor app on windows, it does not work at all. Sometimes, I have issues to install meteor dependencies, but when I have all required dependencies it still faill to boot : 

[[[[[ Tests ]]]]]

=> Started proxy.
=> Started MongoDB.
=> Linted your app. No linting errors.
W20160623-19:46:04.852(2)? (STDERR)
W20160623-19:46:05.054(2)? (STDERR) C:\Users\serut\AppData\Local\.meteor\packages\meteor-tool\1.3.4\mt-os.windows.x86_32\dev_bundle\server-lib\node_modules\fibers\future.js:280
W20160623-19:46:05.057(2)? (STDERR)                                             throw(ex);
W20160623-19:46:05.059(2)? (STDERR)                                                   ^
W20160623-19:46:05.060(2)? (STDERR) TypeError: Cannot call method 'push' of undefined
W20160623-19:46:05.062(2)? (STDERR)     at meteorInstall.node_modules.meteor.practicalmeteor:mocha-core.node_modules.mocha.lib.mocha.js (node_modules/meteor/practicalmeteor:mocha-core/node_modules/mocha/lib/mocha.js:28:1)
W20160623-19:46:05.065(2)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160623-19:46:05.068(2)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160623-19:46:05.070(2)? (STDERR)     at meteorInstall.node_modules.meteor.practicalmeteor:mocha-core.node_modules.mocha.index.js (node_modules/meteor/practicalmeteor:mocha-core/node_modules/mocha/index.js:3:1)
W20160623-19:46:05.073(2)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160623-19:46:05.075(2)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160623-19:46:05.077(2)? (STDERR)     at meteorInstall.node_modules.meteor.practicalmeteor:mocha-core.server.js (packages/practicalmeteor:mocha-core/server.js:2:1)
W20160623-19:46:05.080(2)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160623-19:46:05.082(2)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160623-19:46:05.094(2)? (STDERR)     at node_modules/meteor/practicalmeteor:mocha-core/node_modules/mocha/node_modules/growl/lib/growl.js:234:1
=> Started your app.

=> App running at: http://localhost:3000/

on windows 10 Someone using windows can confirm the issue ?

I also have issue to install dependencies of your pull request on windows (can help maybe?). 

C:\> git clone https://github.com/aldeed/todos aldeed.todos
C:\> cd aldeed.todos
C:\aldeed.todos [master ≡]> npm install
[..]
C:\aldeed.todos [master ≡]> meteor
[[[[[ C:\aldeed.todos ]]]]]
=> Started proxy.
=> Meteor 1.3.4 is available. Update this project with 'meteor update'.
=> Started MongoDB.
=> Started your app.
=> App running at: http://localhost:3000/

C:\aldeed.todos [master ≡]> meteor test --once --driver-package dispatch:mocha-phantomjs
[[[[[ Tests ]]]]]
=> Started proxy.
=> Started MongoDB.
=> Meteor 1.3.4 is available. Update this project with 'meteor update'.
Unable to resolve some modules:
  "sass" in
/C/Users/serut/AppData/Local/.meteor/packages/practicalmeteor_mocha-core/1.0.0/npm/node_modules/mocha/node_modules/jade/lib/filters.js
(web.browser)
[same error a lot of time..]
Consider running: meteor npm install --save sass stylus less markdown discount markdown-js marked coffee-script
_process base64-js ieee754 is-array core-util-is inherits isarray string_decoder readable-stream browser-stdout
tmeasday commented 8 years ago

Looks great! (Although some tests are failing, not sure it's related though)

aldeed commented 8 years ago

Yeah I saw two failing tests but it didn't seem to be related.