search

meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

improve circle ci tests #161

Closed DominikGuzei closed 8 years ago

apollo-cla commented 8 years ago

@DominikGuzei: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

tmeasday commented 8 years ago

Interesting. Can you explain the rationale in moving the chimp command out of package.json into it's own script?

DominikGuzei commented 8 years ago

@tmeasday that was done because i ran into several issues with chimp and Node.js 0.10.x that Meteor is using. So the problem is that if you run Node via meteor npm run you are forced to the Meteor node version. if you run it from outside you can have Node.js 5+ installed globally and basically run Meteor and chimp with different versions.

Here are the related Github issues and discussions: https://github.com/xolvio/chimp/issues/204 https://github.com/xolvio/chimp/issues/201

Bottom line: Meteor really has to upgrade to use up-to-date Node.js versions soon. Until then, we cannot use the package.json with chimp.

tmeasday commented 8 years ago

Makes sense @DominikGuzei.

We just updated the master branch to 1.3.4.4, can you please rebase/merge?

PS we now have a 1.4-beta.10 release; if you'd prefer to write this PR against that, and we can merge this in at the same time as updating to 1.4?

DominikGuzei commented 8 years ago

damn … that's why you should never use rebase. Just screwed up the whole PR 😢 Reopened at #164