Closed DominikGuzei closed 8 years ago
Let's do it!
Thanks @DominikGuzei !
Looking at the output of CircleCI, it looks like this isn't running any tests. Am I missing something?
https://circleci.com/gh/meteor/todos/271
./tests/acceptance_run
[[[[[ ~/todos ]]]]]
=> Started proxy.
=> Started MongoDB.
=> Started your app.
Test app is running …
=> App running at: http://localhost:3100/
[chimp] Running...
0 passing (4ms)
Chimp CI exited with code 0
@noahsw the problem of no running CI tests is fixed in https://github.com/meteor/todos/pull/171 😉 thanks for the feedback.
Fixes the CircleCi tests and improves performance by caching all important parts of the application and test dependencies.
The chimp script is moved outside of the
package.json
file because i ran into several issues with chimp and Node.js 0.10.x that Meteor is using. So the problem is that if you run Node viameteor npm run
you are forced to the Meteor node version. if you run it from outside you can have Node.js 5+ installed globally and basically run Meteor and chimp with different versions.Here are the related Github issues and discussions: https://github.com/xolvio/chimp/issues/204 https://github.com/xolvio/chimp/issues/201
Bottom line: Meteor really has to upgrade to use up-to-date Node.js versions soon. Until then, we cannot use the
package.json
with chimp.This also removes the unit and app-tests from the CircleCi run since they fail for me. Probably i should also fix these but i do not have enough time at the moment 😢