re-enable unit and full-app tests

meteor / todos

The example app "Todos", written following the Meteor Guide

Other

535 stars 367 forks source link

re-enable unit and full-app tests #172

Open noahsw opened 8 years ago

noahsw commented 8 years ago

Tests were removed from CI in https://github.com/meteor/todos/pull/164 but they're working fine for me on master so we should add them back.

Open question is whether we should be running meteor npm install or npm install, but let's see if CI passes.

mrmowgli commented 8 years ago

How did you get the file permissions to work on circlecl? I'm trying to update the tests in the coffeescript branch, and am running into this. I assume I should be modifying the pre section of the circle.yml?

hwillson commented 8 years ago

Hi @noahsw - thanks for the PR. Are you still working on this? Let me know if you are, or if you'd like me to take a look.

noahsw commented 7 years ago

Hi @hwillson - sorry I ran into CI problems and had to take a break. Maybe this is why the tests were removed in the first place... I hope someone can figure it out though!

hwillson commented 7 years ago

No problem @noahsw - I'll take a look. Thanks again!

GeoffreyBooth commented 7 years ago

See also #210

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: noahsw
:x: DominikGuzei
_{You have signed the CLA already but the status is still pending? Let us recheck it.}