tmeasday
commented
8 years ago Appreciate this @hwillson! It looks like the package.json is NQR though -- the eslint plugins are at the wrong versions maybe? (see test failure)
Closed hwillson closed 8 years ago
tmeasday
commented
8 years ago Appreciate this @hwillson! It looks like the package.json is NQR though -- the eslint plugins are at the wrong versions maybe? (see test failure)
hwillson
commented
8 years ago Hi @tmeasday - yes, I'm looking at it now. Updates coming shortly. Thanks!
hwillson
commented
8 years ago Sorry about that @tmeasday - the versions were okay but I didn't notice the shrinkwrap that was in place. I've updated the shrinkwrap so things should now build properly. That being said, CircleCI is taking quite a while with the build - it's still queued (has been for about 30 minutes now). I'll keep an eye on it but something seems a little off.
tmeasday
commented
8 years ago No worries. I think circle is just backed up behind some meteor commits right now, nbd.
hwillson
commented
8 years ago Great - looks better now @tmeasday; thanks again.
BTW - I know you guys are swamped with Apollo these days, so if you're ever looking for a hand with managing this repo, I'd be glad to join in and help clear out PR's, keep things up to date, etc.
tmeasday
commented
8 years ago That'd be great! I'll add you as a maintainer
hwillson
commented
8 years ago Awesome - thanks!
Hi guys - here's a quick PR to bring the Blaze version of the todos app up to date in terms of Meteor version, packages, deps, etc. Here's a more detailed breakdown:
import/prefer-default-export- since default exports aren't really used in the todos app I've shut this rule off.object-shorthand- I've set avoidQuotes to false to disable the error when using object shorthand syntax with string literals (which the todos app does in a few places).I'll update the
reactbranch as well. Let me know if you have any questions or want anything changed. Thanks!