search

meteor / todos

The example app "Todos", written following the Meteor Guide
Other
535 stars 367 forks source link

Updating circle.yml to reflect CircleCI.com #211

Closed NickBusey closed 7 years ago

NickBusey commented 7 years ago

I cloned the project and pushed my repo to CircleCI, it failed. Then I noticed the circle.yml that CircleCI.com reported was different than that in the repo. Updated my circle.yml to match CircleCI's copy, and it worked. So this file needs version bumped.

apollo-cla commented 7 years ago

@NickBusey: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

hwillson commented 7 years ago

Hi @NickBusey - thanks for submitting this PR. I'm not sure this is necessary though, as CircleCI builds are passing with the current versions in the circle.yml. See https://circleci.com/gh/meteor/todos/336 as an example. We intentionally switched the node version to 4.6.2 to make sure it was using the latest version supported by Meteor. Can you provide a link to your failed CircleCI build? Thanks!

NickBusey commented 7 years ago

Here is a failed run: https://circleci.com/gh/NickBusey/BulletNotes/37

I made one commit, changing the version numbers: https://github.com/NickBusey/BulletNotes/commit/5155e02454a61e30fbdfe5020d70c5999e38d9d2

And the next run succeeded: https://circleci.com/gh/NickBusey/BulletNotes/38

abernix commented 7 years ago

Thanks for trying to fix this, but unfortunately, I think that failure was a fluke and (even more unfortunately) no error context was provided by the (silently) failing script. Regardless, there is no indication that it had anything to do with the Node version. Basically, I think if you had just re-run that build (with the CircleCI Rebuild button), it would have passed.

Thanks again for giving it a shot though!

NickBusey commented 7 years ago

Fair enough, but I think then that maybe some documentation needs changed to say that perhaps things need to be run multiple times before deciding that they've failed?

abernix commented 7 years ago

If this continues to be a recurring problem, I think that's a fair consideration, but as of right now there's no reason to say that wasn't just a general CircleCI failure or something else completely unpredictable. I'm not aware that it's been a trend. Thanks for the suggestion.