Closed lorensr closed 7 years ago
Sorry @lorensr, I'm not ignoring this - it's been a hectic week! I'll definitely take a look at this soon. Thanks!
Some people have problems with Nightmare and Linux (eg https://github.com/meteor/todos/issues/198#issuecomment-292586439) but looks like this PR's CI passed
Hi @lorensr - would you mind rebasing when you have a sec? I'll dig in to review this right after. Thanks!
@hwillson rebased
Thanks @lorensr, these changes look good to me! Outside of these changes, some people might get confused seeing 2 different *:mocha
packages configured (dispatch:mocha
for console and practicalmeteor:mocha
for browser), but that’s an issue for another day/PR. Thanks for making these changes!
Looks like
dispatch:mocha-phantomjs
is deprecated:https://forums.meteor.com/t/is-anyone-testing-their-meteor-apps/34027/17
The recommended package
dispatch:mocha
with nightmare is working for me. Would someone like to confirm it works for them too?