search

meteorengineer / setup-meteor

Set up your GitHub Actions workflow with a specific version of Meteor.js
MIT License
19 stars 9 forks source link

Caching Meteor binaries #8

Open jankapunkt opened 4 years ago

jankapunkt commented 4 years ago

Thank you for this great package. I am still new to Actions and tried to find out, if this action already caches the Meteor install as I think it is a bit overkill for every push and pr to install the Meteor binary again.

If this is not currently supported, do you think it would be feasible to add this feature and maybe a flag to the config like cache: true?

mpowaga commented 4 years ago

It is not cached. I don't think there is significant difference in speed between downloading a tarball and decompressing it vs downloading uncompressed binaries. Meteor installation takes less than 20 seconds (check this build) so even if we make it 50% faster it won't make much difference.

However if someone doesn't want to overload Meteor's CDN and use its own cache instead then it would make sense to add this option.

mpowaga commented 4 years ago

Just checked windows build and it takes 4 minutes to setup Meteor. So it might be worth adding this option for windows at least.