meteorhacks / meteor-inject-initial

Allow injection of arbitrary data to initial Meteor HTML page
Other
78 stars 11 forks source link

Inject string with $ sign #11

Closed josephros closed 10 years ago

josephros commented 10 years ago

Consider this example of injecting into a particular result object: (note the number of $ signs in the injected EJSON representations vs the data objects set)

Inject.obj("test", {data: "yo $ yo"}, res); leads to <script id='test' type='application/ejson'>{"data":"yo $ yo"}</script>

Inject.obj("test", {data: "yo $$ yo"}, res); leads to <script id='test' type='application/ejson'>{"data":"yo $ yo"}</script>

Inject.obj("test", {data: "yo $$$ yo"}, res); leads to <script id='test' type='application/ejson'>{"data":"yo $$ yo"}</script>

I can't seem to work out why this is occurring, especially with Meteor's new package system making it hard to modify/debug meteor packages on the fly.

It doesn't seem to be a problem with the EJSON.stringify method as running it on the same data objects yields the expected result (ie the correct number of $ signs in each EJSON representation).

Any help would be much appreciated!

gadicc commented 10 years ago

Confirmed, problem on our side since $ has special meaning in string replacement. Will release a fixed version soon.

gadicc commented 10 years ago

@arunoda, let me know if you have any luck publishing this :>

$ meteor publish
Refreshing package metadata. This may take a moment.
Reading package...
Figuring out the best package versions to use. This may take a moment.
arunoda commented 10 years ago

I think you don't have the permission. That may be the reason. I tried to add you no luck. Do you know how.

I'll do a release now.


Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda

On Fri, Sep 12, 2014 at 9:51 PM, Gadi Cohen notifications@github.com wrote:

@arunoda https://github.com/arunoda, let me know if you have any luck publishing this :>

$ meteor publish Refreshing package metadata. This may take a moment. Reading package... Figuring out the best package versions to use. This may take a moment.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/meteor-inject-initial/issues/11#issuecomment-55426317 .

josephros commented 10 years ago

Thanks for looking at this so quickly.

Side question: How exactly do I pull in version 1.0.1 from meteor? I tried meteor add but it keeps pulling in the 1.0.0 version?

gadicc commented 10 years ago

Hey, sorry, both Arunoda and I tried and failed to publish the package. We were hoping it was a temporary error with the Meteor server, but it seems like a bigger issue that we'll need to follow up with MDG.

In the meantime, you might have to clone the repro into your package directory (the smart.json is a bit out of date which precludes doing this with mrt, perhaps we'll dedeprecate it if more issues like this arise). Will continue to update on this.

arunoda commented 10 years ago

I did yesterday also. I think, it's with the name of inject-initials. Or may be not. I could publish fast-render without any issues.


Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda

On Tue, Sep 16, 2014 at 1:16 PM, Gadi Cohen notifications@github.com wrote:

Hey, sorry, both Arunoda and I tried and failed to publish the package. We were hoping it was a temporary error with the Meteor server, but it seems like a bigger issue that we'll need to follow up with MDG.

In the meantime, you might have to clone the repro into your package directory (the smart.json is a bit out of date which precludes doing this with mrt, perhaps we'll dedeprecate it if more issues like this arise). Will continue to update on this.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/meteor-inject-initial/issues/11#issuecomment-55707546 .

gadicc commented 10 years ago

Blah, I finally isolated this down to the smallest possible reproduction only to find it was fixed yesterday in https://github.com/meteor/meteor/issues/2585 :) The fix (for Meteor) isn't released yet but I could publish the package using Meteor from devel#head. @josephros, you can go ahead and update now :>