meteorhacks / search-source

Reactive Data Source for Search
MIT License
145 stars 33 forks source link

Consider options for cached history. #34

Closed kueblboe closed 9 years ago

kueblboe commented 9 years ago

I am using the options parameter to pass filter and sort parameter for the search. If combined with a limit this returns incorrect results, when the search term (query) stays the same, but the filter or sort parameters are changed, since this doesn't trigger a new search on the server. To fix this I stringify the options and add them to the query to use as history key.

arunoda commented 9 years ago

Okay. This is great. This is what I want from #14

I'll take this. So, this will be help to do pagination right?

kueblboe commented 9 years ago

14 is a bigger and more sophisticated issue which could happen on top of this. My simple change just fixes the issue that you cannot use the local history when you want to use sort or filter together with a limit. That's why I think this small change has value on its own.

arunoda commented 9 years ago

Yes it is. That's why I like to take this in.

viktorzp commented 8 years ago

hi guys...) pls tell me, is it possible to use pagination in this serch package?