Breaks velocity meteor-cucumber

geekyme commented 9 years ago

Hey there, great work on this package. One minor problem though... when my meteor app (with its test suite) is first started, everything ran fine - my tests run and everything passed as expected.

However, when I make an edit to my cucumber step files and save, eg.

this.Given(/blah$/, function (callback) {
    helper.world.browser
      .url(helper.world.mirrorUrl)
      .executeAsync(function(done){
        Meteor.loginWithPassword('testuser1', 'testpassword', function(err){
          done(err || true)
        });
      }, function(err, ret){
        assert.deepEqual(true, ret.value);
      })
      .call(callback)
  });

My cucumber log (from .meteor/local/log/cucumber.log) shows this

[velocity-mirror] Mirror is initializing...
The package alanning:package-stubber at 0.0.15 is incompatible with Meteor 0.9.0 or later. 
If a new, compatible version of this package exists, running 'meteor update' should cause you to update. 
Sikka: starting with these configurations: {"captcha":{"siteKey":"xxx","secret":"xxx"},"rateLimits":{"perIp":20,"perHuman":20,"perSession":20},"times":{"blockIpFor":120000,"humanLivesUpto":3600000},"onlyForHumans":false}
LISTENING
[velocity-mirror] Mirror is ready.
Sikka: IP Blocked. 127.0.0.1
Sikka: Closing current connection 5Bw7wJMxiAiFk6d8t

arunoda commented 9 years ago

Okay. May be we need to add a feature to disable Sikka locally or detect velocity and block it.

On Wed, Apr 1, 2015 at 6:12 AM Shawn Lim notifications@github.com wrote:

Hey there, great work on this package. One minor problem though... when my meteor app (with its test suite) is first started, everything ran fine - my tests run and everything passed as expected.

However, when I make an edit to my cucumber step files and save, eg.

this.Given(/blah$/, function (callback) { helper.world.browser .url(helper.world.mirrorUrl) .executeAsync(function(done){ Meteor.loginWithPassword('testuser1', 'testpassword', function(err){ done(err || true) }); }, function(err, ret){ assert.deepEqual(true, ret.value); }) .call(callback) });

My cucumber log (from .meteor/local/log/cucumber.log) shows this

[velocity-mirror] Mirror is initializing... The package alanning:package-stubber at 0.0.15 is incompatible with Meteor 0.9.0 or later. If a new, compatible version of this package exists, running 'meteor update' should cause you to update. Sikka: starting with these configurations: {"captcha":{"siteKey":"xxx","secret":"xxx"},"rateLimits":{"perIp":20,"perHuman":20,"perSession":20},"times":{"blockIpFor":120000,"humanLivesUpto":3600000},"onlyForHumans":false} LISTENING [velocity-mirror] Mirror is ready. Sikka: IP Blocked. 127.0.0.1 Sikka: Closing current connection 5Bw7wJMxiAiFk6d8t

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/sikka/issues/10.

arunoda commented 9 years ago

@samhatoum any ways to determine whether the meteor process is a velocity mirror or not?

samhatoum commented 9 years ago

yep, easy. process.env.IS_MIRROR :)

arunoda commented 9 years ago

Nice. Thanks. On 2015 අප්‍රේල් 1, බදාදා at පෙ.ව. 7.16 Sam Hatoum notifications@github.com wrote:

yep, easy. process.env.IS_MIRROR :)

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/sikka/issues/10#issuecomment-88308347.

geekyme commented 9 years ago

is there going to be a release to fix this issue?

meteorhacks / sikka

Breaks velocity meteor-cucumber #10