meteorhacks / sikka

Sikka - A Firewall for Meteor Apps
MIT License
259 stars 23 forks source link

fix bad content-type in captcha response #15

Open sclausen opened 9 years ago

sclausen commented 9 years ago

In some undiscovered cases, the content-type of the captcha-page will be text/plain instead of text/html. a blank new meteor-project with sikka doesn't send the captcha-page in text/html, but unfortunately my more complex meteor-app does. I don't know why, but the response content-type in line 42 seems to be wrong. It should be 'text/html' not 'html'. Changing this fixed the problem for me.

sys13 commented 8 years ago

This pull-request was necessary for me to use Sikka as well. I think it should be merged.

sys13 commented 8 years ago

Pinging @arunoda since there haven't been updates to this repo/pull-request for a while.

michaelrokosh commented 7 years ago

@arunoda I have the same issue.

MaxPleaner commented 7 years ago

I was going to make a PR for the same change but realized I forgot to check if someone had done it first. Thanks!

MaxPleaner commented 7 years ago

Maybe the https://github.com/xunga/sikka-CM fork would be better to use, since it's been updated more than this repo.