meteorhacks / zones

Zone.js integration for meteor
MIT License
30 stars 11 forks source link

Refactor reporters #9

Closed thani-sh closed 10 years ago

arunoda commented 10 years ago

You need to remove the first line from all the stack traces, but not the first one. See below:

TypeError: Cannot read property 'total' of null
    at http://localhost:3000/app.js?a8a8569605ff8ed3c97b134a8210f83fdab3dd6b:20:21

> Before: 301ms (diff: 301ms)
Error
    at afterGetData (http://localhost:3000/app.js?a8a8569605ff8ed3c97b134a8210f83fdab3dd6b:19:5)

> Before: 307ms (diff: 6ms)
Error
    at Object.Template.main.events.click button (http://localhost:3000/app.js?a8a8569605ff8ed3c97b134a8210f83fdab3dd6b:13:14)
    at http://localhost:3000/packages/ui.js?9419ac08328918a04e7a49464a988d45f851e1b0:426:30
    at Object._assign.nonreactive (http://localhost:3000/packages/deps.js?4a82362ae66e863a1c1a8b0a5fec6f665e2038d1:400:14)
    at UI.Component.notifyParented._.each.wrappedHandler (http://localhost:3000/packages/ui.js?9419ac08328918a04e7a49464a988d45f851e1b0:417:21)
    at HTMLButtonElement.<anonymous> (http://localhost:3000/packages/ui.js?9419ac08328918a04e7a49464a988d45f851e1b0:1587:24)
    at HTMLBodyElement.jQuery.event.dispatch (http://localhost:3000/packages/jquery.js?265926494aaa3929cd2e30da265211c5929f37a4:4657:9)

We don't need a message as Error just below the before times.

thani-sh commented 10 years ago

In Firefox, there's no 'Error' line so it'll remove a trace line. We can edit the regex a bit to remove a line which only contains Error

arunoda commented 10 years ago

Okay. Then add some custom error message like Zone False Error and remove it.


Arunoda Susiripala

@arunoda http://twitter.com/arunoda http://gplus.to/arunodahttps://github.com/arunoda http://www.linkedin.com/in/arunoda

On Tue, Jul 15, 2014 at 2:53 PM, Muhammed Thanish notifications@github.com wrote:

In Firefox, there's no 'Error' line so it'll remove a trace line. We can edit the regex a bit to remove a line which only contains Error

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/meteor-zones/pull/9#issuecomment-49008818 .