search

meteoric / meteor-ionic

Ionic components for Meteor. No Angular!
http://meteoric.github.io
MIT License
1.51k stars 219 forks source link

ionSlideBox destroyed callback #146

Closed guilhermedecampo closed 9 years ago

guilhermedecampo commented 9 years ago

Hi @nickw!

Why we need this unslick on ionSlideBox destroyed callback?

https://github.com/meteoric/meteor-ionic/blob/ff882994ca1bc5f93b0119c6e6f3e7b870c96dd0/components/ionSlideBox/ionSlideBox.js#L30

It give me errors because maybe this element $('.ion-slide-box') does not exists at this point.

Also it's a little bit ugly see all the images of ionSlideBox when you change screens.

nickw commented 9 years ago

Hmm maybe we don't. Maybe there could be memory leaks though if we keep re-initializing the plugin?

guilhermedecampo commented 9 years ago

Don't know @nickw about the memory leaks.

But maybe we can just check if the element indeed is there?

I can make a pull request! ;)

nickw commented 9 years ago

Sounds good, PRs are always welcome!

guilhermedecampo commented 9 years ago

Hey @nickw, in the end I was using it wrong :disappointed:

I don't receive the error anymore.

But is still ugly see the images being in a list in the transition.

Will try to find a solution for that.

Do you have a clue?

nickw commented 9 years ago

But is still ugly see the images being in a list in the transition.

I'm not sure exactly what you mean by this, but I assume it's a FOUC type situation? In that case maybe you just need to add a preloader to that route?