search

meteoric / meteor-ionic

Ionic components for Meteor. No Angular!
http://meteoric.github.io
MIT License
1.51k stars 219 forks source link

add ionic spinners #291

Closed jorjordandan closed 9 years ago

jorjordandan commented 9 years ago

There is currently some styles in the ionSpinner html template needed for testing, until the newer dist of ionic for ionic-sass is merged. Other than that, I think everything works.

nickw commented 9 years ago

@jorjordandan maybe we should also bump the ionic-sass dependency in this package so users don't end up with an old version of the CSS?

jorjordandan commented 9 years ago

Probably a good idea, since without css the spinners take up the whole page. There was no dependency listed for meteoric:ionic-sass in the package.js or versions.json - the only place I found a reference was in the guide. Did you just mean I should specify the version in the guide? Or are you adding the dependency some way that I'm not familiar with?

nickw commented 9 years ago

Oh you're right, I think I deliberately didn't specify a dependency on ionic-sass so that users could bring their own version if they wished (compiled CSS, a LESS version, etc). So maybe it's OK as is.

jorjordandan commented 9 years ago

Okay I'll take care of those issues as soon as possible, thanks for the feedback!