search

meteoric / meteor-ionic

Ionic components for Meteor. No Angular!
http://meteoric.github.io
MIT License
1.51k stars 219 forks source link

Fix spinner assignment and formatting issues #293

Closed jorjordandan closed 9 years ago

jorjordandan commented 9 years ago

Looks like I got a little ahead of myself before....

I hope this is better - I'm adding the icon to a class name (as the last class) , and then grabbing it on my rendered callback. I tried to pass it through the template data context, but couldn't (it's read only). I'm not sure how else to pass the icon name.

jorjordandan commented 9 years ago

Changed <div> to <i> element which fixed display issue, and matches the ionIcon tags anyways.

nickw commented 9 years ago

Ah good call.

nickw commented 9 years ago

@jorjordandan this is looking good, but I noticed in my testing (https://github.com/meteoric/demo/blob/master/client/templates/spinner/spinner.html) that the Android spinner doesn't animate. Any ideas?

nickw commented 9 years ago

Not sure if the below error is related:

ReferenceError: $element is not defined
    at start (ionSpinner.js:445)
    at init (ionSpinner.js:440)
    at Template.ionSpinner.rendered (ionSpinner.js:422)
    at template.js:116
    at Function.Template._withTemplateInstanceFunc (template.js:437)
    at fireCallbacks (template.js:112)
    at null.<anonymous> (template.js:205)
    at view.js:104
    at Object.Blaze._withCurrentView (view.js:523)
    at view.js:103