Closed Mrminfive closed 5 years ago
Thanks for your PR.
The customizable issue content could be a useful feature for some users. Some discussions:
options
and props
, so the issueContent
computed may be placed in Vssue.vue
but not in VssueStore.ts
(like the issueTitle
computed).string
now).It has been modified now.
Why not use async functions ?
@Mrminfive
Great thanks~
This feature has been released in v0.7.0
I'm not sure if it's necessary to use async functions, so I remove it. If you need this feature, we can try to support it in future PR.
BTW, Object.prototype.toString.call(asyncFunction)
returns "[object AsyncFunction]"
in Chrome, not "[object Promise]"
Yes, I have a scene that needs to use an asynchronous function.
Thank you for your reminder.
@Mrminfive
Could you please provide a example for why you need async function? In my mind, almost all the common scene could be solved by function.
I need to replace issueContent with the contents of the md file. It is not reasonable to import the md content directly into the js file, so I need to load the resource asynchronously.
@Mrminfive
Support async function for issueContent
in v0.7.1
thx
configurable comment body