meteorlxy / vssue

:mailbox: A Vue-powered Issue-based Comment Plugin
https://vssue.js.org
MIT License
773 stars 106 forks source link

feat($vssue): configurable issue body #10

Closed Mrminfive closed 5 years ago

Mrminfive commented 5 years ago

configurable comment body

meteorlxy commented 5 years ago

Thanks for your PR.

The customizable issue content could be a useful feature for some users. Some discussions:

Mrminfive commented 5 years ago

It has been modified now.

Mrminfive commented 5 years ago

Why not use async functions ?

meteorlxy commented 5 years ago

@Mrminfive

Great thanks~

This feature has been released in v0.7.0

I'm not sure if it's necessary to use async functions, so I remove it. If you need this feature, we can try to support it in future PR.

BTW, Object.prototype.toString.call(asyncFunction) returns "[object AsyncFunction]" in Chrome, not "[object Promise]"

Mrminfive commented 5 years ago

Yes, I have a scene that needs to use an asynchronous function.

Thank you for your reminder.

meteorlxy commented 5 years ago

@Mrminfive

Could you please provide a example for why you need async function? In my mind, almost all the common scene could be solved by function.

Mrminfive commented 5 years ago

I need to replace issueContent with the contents of the md file. It is not reasonable to import the md content directly into the js file, so I need to load the resource asynchronously.

meteorlxy commented 5 years ago

@Mrminfive

Support async function for issueContent in v0.7.1

Mrminfive commented 5 years ago

thx