fix(api-gitlab-v4): workaround for gitlab redirect_uri issue (close #99)

meteorlxy / vssue

:mailbox: A Vue-powered Issue-based Comment Plugin

https://vssue.js.org

MIT License

779 stars 107 forks source link

fix(api-gitlab-v4): workaround for gitlab redirect_uri issue (close #99) #101

Closed mohan43u closed 3 years ago

mohan43u commented 4 years ago

fix(api-gitlab-v4): workaround for gitlab redirect_uri issue (close #99)

mohan43u commented 4 years ago

I have fixed gitlab redirect_uri issue. Also fixed related test cases as well as code coverage. I would like to see this PR reviewed and hopefully merged.

CieNTi commented 4 years ago

Thanks for all your work @meteorlxy and @mohan43u .. great system!

Do you have some expectation on when this feature will be added to an official release of vssue?

Thanks!

CieNTi commented 4 years ago

Hi again!

It is possible to use your version @mohan43u ? I cannot figure how to use a named-space plugin out of the original source, and is not possible to add dependencies based on a subfolder of a repository.

How can I use it while we wait for official releases that fix support to Gitlab?

Thanks!

mohan43u commented 4 years ago

@CieNTi you have to build vssue.gitlab.min.js, here is the steps

Install yarn which will automatically install node
From the cloned directory run following command to install dependencies
```
$ yarn install
```
Then run lint
```
$ yarn lint
```
Then run build, this will generate packages/vssue/dist/vssue.gitlab.min.js file, use this file in your project
```
$ yarn build
```
You should also run the testcases
```
$ yarn test
```

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.