search

meteorlxy / vssue

:mailbox: A Vue-powered Issue-based Comment Plugin
https://vssue.js.org
MIT License
775 stars 105 forks source link

[Feature Request] - Enhance the way of using secretkey #133

Closed Realvincentyuan closed 3 years ago

Realvincentyuan commented 3 years ago

What problem does the feature solve?

Currently the Github OAuth app secret key is explicitly specified in the front end, wish to add a patch for this design.

Proposed solution

Put the key in an implicit way, at least it will not be shown in the front end.

Alternative solutions

N/A

Additional context

In some cases where data privacy rules are implemented in enterprise environment, exposure of such keys is against the company data privacy rules and commits of this kind are not allowed.

meteorlxy commented 3 years ago

Use can deploy you own proxy server, putting your key on the server, then set the proxy option of vssue.

In short, currently vssue is a pure front-end project. If you don't want to store the key in the front-end, it's out of the scope of current version of vssue.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.