search

meteorlxy / vssue

:mailbox: A Vue-powered Issue-based Comment Plugin
https://vssue.js.org
MIT License
773 stars 106 forks source link

i18n: pt-BR support #18

Closed tgmti closed 5 years ago

tgmti commented 5 years ago

Hello,

following this, in lunch I Started add pt-BR support.

basicaly it´s only this? https://github.com/meteorlxy/vssue/compare/master...tgmti:ptBRSupport

If it´s ok, next i´ll start the docs change.

what you think is better? push all on finish, or create two sepparate PR´s?

tgmti commented 5 years ago

ptBR docs is ready: https://github.com/tgmti/vssue/compare/master...tgmti:docsi18nptBR

tgmti commented 5 years ago

And in order to change docs, i tested the plugin changes image

meteorlxy commented 5 years ago

Great thanks @tgmti !

Seperated PR is preferred, as they are for different types of change (feat and docs)

meteorlxy commented 5 years ago

I think the prefix of docs should be pt-BR rather than ptBR.

i.e. the dirname : docs/ptBR/... => docs/pt-BR/...

tgmti commented 5 years ago

Cool, changed, sending PR´s