search

meteorrn / meteor-react-native

Meteor client for React Native matching Meteor Spec
https://guide.meteor.com/react-native.html
Other
60 stars 33 forks source link

Replaced wolfy87-eventemitter with core EventEmtiter from 'events' #116

Closed jankapunkt closed 1 year ago

jankapunkt commented 1 year ago

implementes #112

TheRealNate commented 1 year ago

@jankapunkt can you resolve merge conflicts, GitHub keeps giving me issues

jankapunkt commented 1 year ago

@TheRealNate yes I will look at them

jankapunkt commented 1 year ago

@TheRealNate resolved

jankapunkt commented 1 year ago

Thanks @TheRealNate I will create a new release 2.5.0 and publish on NPM.

juanpmd commented 1 year ago

@jankapunkt does this change require installing the npm package events? I am having problems running meteorrn without it but wanted to make sure this is the correct way.

jankapunkt commented 1 year ago

Hey @juanpmd I investigated and it seems to be a mistake from my end here. The tests never catched this, since they run with node, which itself holds events but the React Native engine doesn't know about events and it's not possible to simply install them. The npm events package is also not an official core package and not maintained since two years. I'm thinking if finding a good solution here, maybe eventemitter3?

jankapunkt commented 1 year ago

@juanpmd can you please take a look at PR #129 and let me know if this works for your setup without the need for the events dependency?