search

meteorrn / meteor-react-native

Meteor client for React Native matching Meteor Spec
https://guide.meteor.com/react-native.html
Other
59 stars 31 forks source link

[Feature Request] Add OAuth functions for Facebook and Google #36

Closed diavrank closed 1 year ago

diavrank commented 4 years ago

Is your feature request related to a problem? Please describe. In meteor exists some packages to do Meteor.loginWithFacebook() or Meteor.loginWithGoogle() and the OAuth configuration is saved in _meteor_accountsloginServiceConfiguration collection of MongoDB. Currently, I use it with Vue JS (through akryum package) and it works perfectly.

Describe the solution you'd like It would be great to add this feature with React Native to facilitate this part. I know that exists another social networks to do OAuth but I think that Facebook and Google are the most used. Describe alternatives you've considered I found on other sites another way to do that but it is necessary to install another plugin to connect with Meteor, so, in my case I have already my application with this package. Additional context Add any other context or screenshots about the feature request here.

TheRealNate commented 4 years ago

Hi @diavrank, this looks like a really good feature to add. I'm open to PRs if anyone thinks they can get this working quickly.

TheRealNate commented 4 years ago

After doing some more research, I think it would be a good idea to make these two separate companion packages:

Facebook is the low-hanging fruit as it can work completely via Linking or a WebView, whereas Google requires you to use native APIs on Android.

github-actions[bot] commented 3 years ago

Closing this issue due to no activity. Feel free to reopen.

firrae commented 3 years ago

This remains the main blocker for me to adopt React Native with my projects. If I ever get free time I'd look into helping build it out, but until then I'm willing to jig up something simple to test against if someone else works on it.

diavrank commented 3 years ago

Hi @TheRealNate, I was working on it these days and I have already got the OAuth functions (both) working well. So, I was wondering if I have to publish the companion packages into my account of NPM, or do you need to give me access to your organization of @meteorrn to publish them?

It is worth mentioning that for Facebook, it needs to configure some code on the server-side to make it work. So, for that I plan to do a PR for Meteor repo, to update the package of accounts-facebook.

TheRealNate commented 3 years ago

Hey @diavrank, thank you for your work in advancing this feature! I've gone ahead and created https://github.com/meteorrn/oauth-facebook and https://github.com/meteorrn/oauth-google and given you access. Once the code is loaded in I'll setup a CI/CD to publish them under the @meteorrn npm organization

diavrank commented 3 years ago

Thank you, I'll be updating it this week.