search

meteorrn / meteor-react-native

Meteor client for React Native matching Meteor Spec
https://guide.meteor.com/react-native.html
Other
59 stars 31 forks source link

Remove reference to UNSAFE_componentWillMount #4

Closed TheRealNate closed 3 years ago

TheRealNate commented 4 years ago

componentWillMount has been deprecated and will be removed in React 17.

/src/components/ReactMeteorData.js#L8

PolarisWT commented 4 years ago

I would think that changing this to a componentDidMount() would work. I have not noticed any side-effects locally with this updated.

TheRealNate commented 4 years ago

After doing some more reading on docs, its possible that moving the code into the constructor method may mimic the behavior of componentWillMount better.

PolarisWT commented 4 years ago

I thought about that too, but found no loss of performance or issues yet - although my case is very limited in use so far 🤞 . I am all for better solutions, but struggling to find good ways to test these in a meaningful way.

How are you going about testing? I spent a little time spooling up mocha that was from the react-native-meteor repo, but decided that was a bigger project...

TheRealNate commented 4 years ago

PR #10 has been merged in beta release 2.1.0-beta1

github-actions[bot] commented 4 years ago

Closing this issue due to no activity. Feel free to reopen.

TheRealNate commented 3 years ago

This has been fixed in 2.1.0