meteorrn / meteor-react-native

Meteor client for React Native matching Meteor Spec
https://guide.meteor.com/react-native.html
Other
59 stars 31 forks source link

Remove dependency on batched updates native feature #45

Closed TheRealNate closed 1 year ago

TheRealNate commented 3 years ago

In src/Data.js, the batched updates feature is being used from ReactNative's shims. This dependency needs to be removed to make the package work without native (e.g. for react-native-web)

da314pc commented 3 years ago

I'll start looking into, I've been trying to make the package work with react-native-web

da314pc commented 3 years ago

@TheRealNate Solution I came up with,

use react-dom as a peer dependency,

Were going to have seperate imports based on if this project is web or native,

But I just forked the lib,

changed: import {unstable_batchedUpdates} from "react-dom"

db.batchedUpdates = unstable_batchedUpdates;

There will be a webpack config issue, for Accounts.

I just used the old version of this project based on https://github.com/inProgress-team/react-native-meteor

github-actions[bot] commented 1 year ago

Closing this issue due to no activity. Feel free to reopen.