Closed jankapunkt closed 2 years ago
@jankapunkt re: compatibility, this only need to works on 0.60+. I'll run a test as soon as I can, but if you're able to do it sooner let me know.
I have currently 0.64.3
installed and would use this for integration tests. Is that enough or should I test with another version as well?
@jankapunkt that should be sufficient. Let me know if this is still WIP or you're ready for merging.
@TheRealNate do I need specific bundling or something before I can test the package locally? Simply installing via npm + local path will throw errors like
./node_modules/@meteorrn/core/src/user/Accounts.js 8:16
Module parse failed: Unexpected token (8:16)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|
| class AccountsPassword {
> _hashPassword = hashPassword;
|
| createUser = (options, callback = () => {}) => {
I did not change or update this file and by looking at it it seems that some ESNext features are used but not transpiled correctly. How did you test the package locally last time?
Addition: I also found this to be an issue when importing Accounts.js
to the tests, since the dependencies are not picked up by default by babel.
Update: nevermind, I can acutally use npm pack
and locally install the tar.gz to test everything. I will let you know when I tested it.
I implemented the tests for /lib
but there are still the tests missing for /src
so this is still WIP.
I also had the time to test with my RN dev env and it works fine so far. However I will test, after I have everything finish for merge, again.
@TheRealNate I can't merge, can you do it please? Another question: can you make an NPM rc-release?
@TheRealNate I'd like to ask, if you can lift my permissions? I would like to step up and keep this package maintained. As you might know, I am very active in the community and will give my best to keep the package well and up to date.
However, it would be much easier, if I can merge PRs or publish releases on GitHub and on NPM (I have 2FA enabled there). I could get some people from the community, that actually use this package in production, involved to make reviews. What do you think?
@jankapunkt sorry about the delay. I've added you as a collaborator and am merging this PR.
Upgraded babel to v7 Upgrade react-native preset to
module:metro-react-native-babel-preset
Upgrade mocha/chai/sinon Added nyc for coverage + presets Updated ddp.js testsFixes #26
Note: since this required babel updates this needs to be tested for compatibility.
From here we can start implement all kinds of tests and also wirte intration tests for minimongo-cache which is about to be finished soon
Current coverage (will be updated with each push):