search

metherul / Automaton

The open modpack platform.
Other
59 stars 14 forks source link

Clicking a mod link just as another mod finishes downloading causes Automaton to crash. #62

Open Sentrus opened 5 years ago

Sentrus commented 5 years ago

Log here: https://pastebin.com/fMwKA4mR

I suspect only the last few lines are relevant however.

metherul commented 5 years ago

This'll be fixed when I get the Download / Validate rework in. Hang tight.

nate123456 commented 5 years ago

I would like to add that I got the same exception as is in Sentrus' log. I'm not sure if it was just as another mod was finishing, but I was trying to point Automaton to a mod I had downloaded while it was auto-downloading.

I am mainly commenting to add that I received an error popup notifying me of the exception which itself was non-responsive- it seems that the UI thread is down in that moment, which means that I can't interact with the program to hit the shutdown button available in the popup. It eventually closed on its own as I tried to hit the button, perhaps because it was already shutting down, perhaps because my click got through, or because windows just decided it was non-responsive.

Not that you'd need the suggestion, but it may be possible to salvage the UI thread when catching errors so that the user can experience the shut down popup smoothly.

Best of luck!

I attached the log in case it's of any use.

Automaton_1.3.4.0_5-4-2019 2-40-27 PM.log