search

methnen / m-chart-highcharts-library

Adds Highcharts library to M Chart.
Other
7 stars 1 forks source link

Add accessibility #25

Closed nkryptic closed 2 years ago

nkryptic commented 2 years ago

Adds corresponding Highcharts accessibility.js file. Also adds the ability for a user to enable the accessibility module and/or the export data module (per Highcharts recommendation).

nkryptic commented 2 years ago

I included the docs for that wiki page in the PR (also attached separately). I'm not able to make a PR on the wiki, so wasn't sure the best way to handle it. While it looks like you might have the wiki open to edits from any Github user, it didn't seem appropriate to make the change until the applicable version was live. Let me know your recommendation though, please.

If added, I could change the text Available in M Chart v.1.9.4+ to Available in M Chart Highcharts Library v.1.2.3+ - I figured that and the fact Highcharts is in the hook name would be enough to indicate it is only applicable to Highcarts. I'll update the PR to remove the documentation from the readme files.

FYI, I noticed the wiki section heading filter_m_chart_chartjs_colors was likely supposed to be m_chart_chartjs_colors on the Action/filter hook page.

nkryptic commented 2 years ago

I've made the changes. Here's what would be added to the Action and filter hooks page in the m-chart wiki: m-chart-wiki-add-accessibility-pr.md

methnen commented 2 years ago

Cool, yeah, feel free to make any changes you wish to the wiki and note versions and what not. And if you see a typo I've got no problems with you fixing those. :)

nkryptic commented 2 years ago

I've added the relevant hooks to the wiki page and fixed the typo.