Add support for employee last changed API endpoint

[danielwestendorf]

• Query the most recently changed employees
• Scope to updated, inserted, deleted, or return all changes
• Remove unneeded AS version dependency (it causes dependency conflicts, locks out old rails users)

[danielwestendorf]

Is there a problem with this PR? I see Hound had an error, but I'm unsure how to resolve it.

[enriikke]

Hey @danielwestendorf, thanks so much for taking the time to work on this! We really appreciate it.

We added Hound a little back to help with maintaining a consistent code style across the gem. It works by running rubocop through code changes and commenting on lines that have violations. I'm not sure why the commenting part didn't work this time but you can run rubocop locally. It should be part of the Gemfile so you would only need to run: bundle exec rubocop lib/bamboozled/api/employee.rb and it will check that file (which is the only one you changed).

Let me know if you have any questions about it. Once you update the PR I'll take another look and hopefully we can merge this soon! I'll start drafting a cut for the next minor version.

Feel free to check out the contribution guidelines. It has some other instructions on how to use Guard if you are interested.

Thanks again! :smiley:

[danielwestendorf]

Thanks for the reply. It looks like the rubocop configuration isn't valid. When I run it locally, I get:

$ bundle exec rubocop lib/bamboozled/api/employee.rb
bamboozled/.rubocop.yml: Lint/SpaceBeforeFirstArg has the wrong namespace - should be Style
Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead.
(obsolete configuration found in bamboozled/.rubocop.yml, please update it)

I've created an issue, #16.

I'll readdress this PR after the problems with rubocop are resolved and Hound can run its tests.

[danielwestendorf]

Is this project dead, or is this PR just being ignored? If maintainers are needed, I'd be happy to volunteer.

[enriikke]

Hi @danielwestendorf, sorry I haven't been attentive on this. I realized there were some Rubocop violations and was waiting on those to get fixed but I should have followed up earlier. Would you be able to work on those?

[danielwestendorf]

@Enriikke The rubocop warning should now be resolved, but now CI is failing for certain ruby versions. It looks like the listen gem, a guard dependency, is the failure here as it has strict ruby version requirements.

Installing listen 3.1.3

Gem::InstallError: listen requires Ruby version >= 2.2.3, ~> 2.2.

I'm locking listen in at 3.1.1, as that version doesn't have the ruby version requirements.

[enriikke]

Many thanks for your efforts with this @danielwestendorf!!