search

method-inc / bamboozled

Bamboozled wraps the BambooHR API without the use of Rails dependencies.
MIT License
44 stars 50 forks source link

Fix fetching preferredName when getting all fields #35

Closed artfuldodger closed 5 years ago

artfuldodger commented 7 years ago

nickname was deprecated and replaced with preferredName

https://www.bamboohr.com/api/documentation/employees.php

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.992% when pulling 94a6cb327d875ba10b316181e99143eb933a5f8c on artfuldodger:patch-1 into 96b837a51cf45ec0dbc84827337d71df3acf080e on Skookum:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.992% when pulling 94a6cb327d875ba10b316181e99143eb933a5f8c on artfuldodger:patch-1 into 96b837a51cf45ec0dbc84827337d71df3acf080e on Skookum:master.

artfuldodger commented 5 years ago

I rebased this branch off the current master. Here's the relevant bit of the Bamboo docs:

screen shot 2019-02-01 at 2 34 49 pm
splybon commented 5 years ago

Hey @artfuldodger thanks for this, looks good!

Can you rebase off of develop, and point this PR to merge into develop?

artfuldodger commented 5 years ago

@splybon You got it! Note that if you want to move forward with #42, this change is included there.

splybon commented 5 years ago

Noted. I'll focus more on the other one

chrisman commented 5 years ago

Moving forward with #42 👍

Closing this one out