Implement fetching employees via the custom report endpoint

method-inc / bamboozled

Bamboozled wraps the BambooHR API without the use of Rails dependencies.

MIT License

44 stars 50 forks source link

Implement fetching employees via the custom report endpoint #42

Closed artfuldodger closed 5 years ago

artfuldodger commented 6 years ago

Using the custom report endpoint allows us to get a list of the employees with any fields we want in a much more performant manner than iterating through all the employees and getting additional information one-by-one.

coveralls commented 6 years ago

Coverage increased (+0.7%) to 92.731% when pulling a9be276dbee57948eb8d276577d9e35b4e9774dc on bonusly:custom-reports into 0986b25b0abf0c44e44aaeb2bcdfb7ea4a2cb6b0 on Skookum:master.

coveralls commented 6 years ago

Coverage increased (+0.7%) to 92.731% when pulling 02bfa9e9efd2aa5ff130f2be1b42434d2b971e3e on bonusly:custom-reports into 0986b25b0abf0c44e44aaeb2bcdfb7ea4a2cb6b0 on Skookum:master.

splybon commented 5 years ago

hey @artfuldodger saw your comment in the other PR and this is looking good. Can you fix some of the rubocop errors here? You can click details in the travis-ci checks, or click the link below

https://travis-ci.org/Skookum/bamboozled/jobs/496020015

artfuldodger commented 5 years ago

@splybon I rebased off develop and took care of most of the Rubocop issues. For the remaining issue: I find listing one attribute per line in all_names preferable to having everything on one line (improves, for example, seeing the diff when something changes), so I'm not sure if anything should actually change there. Happy to tweak to match your preferences though.

splybon commented 5 years ago

@artfuldodger I totally agree.

Can you disable that rubocop error then so the linter passes CI? If you add a comment on or above the method line like below: # rubocop:disable Metrics/MethodLength

artfuldodger commented 5 years ago

@splybon Done! Looks like we're all green now.