method-inc / bamboozled

Bamboozled wraps the BambooHR API without the use of Rails dependencies.
MIT License
44 stars 50 forks source link

Create employees #6

Closed kylefdoherty closed 9 years ago

kylefdoherty commented 9 years ago

What's Up

Currently bamboozled is only able to read data from BambooHR accounts. This PR adds the ability to create new employees and will be followed by a PR to allow for the updating employee data.

Changes

1. Bamboozled::API::Employee & Spec

kylefdoherty commented 9 years ago

@markrickert wanted to make sure you saw my PR and see if you had feedback. My company AlphaSights is starting to use BambooHR and we'd love to use this gem, but can't until we're able to create and update users.

markrickert commented 9 years ago

Hey @kylefdoherty - I'm not longer the maintainer of this repository, since I've left Skookum. Pinging @iamdustan to see if someone has the availability to review this and merge it/release a new gem version.

enriikke commented 9 years ago

Hi @kylefdoherty I'm taking a look at your PR. We are currently working towards increasing the gem's scope of supported APIs so this will be a welcomed addition.

kylefdoherty commented 9 years ago

@Enriikke great. If we can get this added, I'll be making PRs for updating employee data, and creating & updating employee photos.

kylefdoherty commented 9 years ago

hi @Enriikke just checking to see if you saw my last to commits that address your comments

enriikke commented 9 years ago

Hi @kylefdoherty, I'm sorry for the late follow up. I must have missed your commits.

Everything looks awesome! Thanks for taking the time to make this gem even better. I'll be pushing this to Rubygems later today. :smiley: :shipit:

kylefdoherty commented 9 years ago

@Enriikke that's great! Thanks for taking the time to review and provide feedback.