Closed kylefdoherty closed 9 years ago
@markrickert wanted to make sure you saw my PR and see if you had feedback. My company AlphaSights is starting to use BambooHR and we'd love to use this gem, but can't until we're able to create and update users.
Hey @kylefdoherty - I'm not longer the maintainer of this repository, since I've left Skookum. Pinging @iamdustan to see if someone has the availability to review this and merge it/release a new gem version.
Hi @kylefdoherty I'm taking a look at your PR. We are currently working towards increasing the gem's scope of supported APIs so this will be a welcomed addition.
@Enriikke great. If we can get this added, I'll be making PRs for updating employee data, and creating & updating employee photos.
hi @Enriikke just checking to see if you saw my last to commits that address your comments
Hi @kylefdoherty, I'm sorry for the late follow up. I must have missed your commits.
Everything looks awesome! Thanks for taking the time to make this gem even better. I'll be pushing this to Rubygems later today. :smiley: :shipit:
@Enriikke that's great! Thanks for taking the time to review and provide feedback.
What's Up
Currently bamboozled is only able to read data from BambooHR accounts. This PR adds the ability to create new employees and will be followed by a PR to allow for the updating employee data.
Changes
1. Bamboozled::API::Employee & Spec
2. Bamboozled::API::Base
response
was being parsed by JSON.parse This was changed toresponse.body
becuase 1) it makes more sense and 2) it will cause an error when posting data to BambooHR successfully becuase theresponse.parsed_response
is nilresponse.headers
are added to the response hash returned by the #request method. This is becuase after a new employee has been created the headers include the "location" i.e. the link for to the employee's page on BambooHR, which contains their BambooHR ID. Most likely if you're creating an employee via the API you're going to want to store the employee's BambooHR ID some where.