search

method-inc / bamboozled

Bamboozled wraps the BambooHR API without the use of Rails dependencies.
MIT License
44 stars 50 forks source link

Bump gem dependencies to latest. #68

Closed cabello closed 5 years ago

cabello commented 5 years ago

Hi! 👋

We got a dependency update PR that bumped bamboozled from 0.0.7 to 0.2.0 and downgraded json from 2.2.0 to 1.8.6.

After closer inspection of this gem dependencies it seems that it would be super safe to upgrade both json and httparty to their latest versions.

json changelog shows no breaking changes but dropping support to old Rubies https://github.com/flori/json/blob/8d8e1aa70297d55034e3f6a4ce2f32300294b2a4/CHANGES.md

httparty changelog shows no breaking changes but dropping support to Ruby < 2 https://github.com/jnunemaker/httparty/blob/99751ac98af929b315c74c2ac0f5ffa09195f7ae/Changelog.md

The gem already requires Ruby >= 2.0 based on the gemspec spec.required_ruby_version = ">= 2.0".

Thanks for considering this change 💜

danhealy commented 5 years ago

👍 Refs #64

splybon commented 5 years ago

@cabello and @danhealy thanks for this! Looks good to me, I am happy to merge. Will probably do a minor release in the next couple of days with this and the applicant tracking

splybon commented 5 years ago

I changed this to merge into develop, but I need to get develop back with master. We made some changes (probably shouldn't have), through github to update the readme and stuff

cabello commented 5 years ago

Thanks for merging it :)