Client and Browser Integration!!

method-inc / skoogle-docs

Ruby Gem to import and transform Google Docs to beautiful HTML and PDF documents

MIT License

2 stars 1 forks source link

Client and Browser Integration!! #12

Closed enriikke closed 9 years ago

enriikke commented 9 years ago

Tied up the client and browser models to work together
Added support for application_name and application version definitions
Refactored browser object to use Skoogle Docs documents
Added support to include SkoogleDocs::Document tests: cassette and factory
Cleaned up documentation
Other minor changes: removed yardstick from guard, fixed guard to run spec on save, etc.

iamdustan commented 9 years ago

I’d love if I could get someone way more qualified than me to be reviewing this. @ruprict?

Also, @patlaughlin to at least give you another venue to be reading ruby

patlaughlin commented 9 years ago

@iamdustan awesome yeah. I'll be keeping an eye on this repo. Potentially writing asinine code reviews

ruprict commented 9 years ago

I did an initial review. I'm sure @Enriikke will want to chat about it. Looks really good, for the most part (except the build failing bit....what up? ;) JRuby ruins everything....)

coveralls commented 9 years ago

Coverage increased (+2.25%) when pulling 7b4b7548e4637bdb4d74a41b40ca640e5a5f4037 on client-wrap into 0f6b07c9e57b3f5bcc6e23dca4804b1e4e939db1 on master.

coveralls commented 9 years ago

Coverage increased (+2.25%) when pulling 9f6a6a1ead072cf50bb53b6d16592c4caf97f86a on client-wrap into 0f6b07c9e57b3f5bcc6e23dca4804b1e4e939db1 on master.

coveralls commented 9 years ago

Coverage increased (+2.49%) to 95.2% when pulling da06f9f4a10fbb77d310acaf750507c8258174ae on client-wrap into 0f6b07c9e57b3f5bcc6e23dca4804b1e4e939db1 on master.

coveralls commented 9 years ago

Coverage increased (+2.49%) to 95.2% when pulling 6bb8871c7a8cebf20ddfb1fb49938592a0fbd445 on client-wrap into 0f6b07c9e57b3f5bcc6e23dca4804b1e4e939db1 on master.

ruprict commented 9 years ago

:shipit: